validation

[atherdon]

https://github.com/25th-floor/spected

[chauhannishith]

What type of validation are you talking about in our form

[atherdon]

first of all - we cannot submit an empty form.
also i think allowedIngredients field is required, because without this field - we'll need to return all info at database

[atherdon]

let's mark this like an open thing. i mean we need validation, for sure. so implement checking if form not empty and add ability to set required fields. also maybe we need to have some notifications, like : "please fill form", etc....

[atherdon]

hold on. i think antd have validation stuff.
@rahuldcoder can you advice us? because we're drowning here :)

[rahuldcoder]

Okay I'll check it out and tell u asap.Will that be fine

[atherdon]

awesome - thank you! On 28-May-2018 at 07:34 PM, Rahul Thakur wrote: Okay I'll check it out and tell u asap.Will that be fine — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#37 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZrDhb8tUVMFJDFod3mD77b2e1CUqviks5t3FFRgaJpZM4UDhhq> .

[chauhannishith]

I still think that this is unnecessary stuff because ingredients, allergy, diet, holiday are unnecessary stuff and not everyone wants to search a specific stuff

• people might be ready for any ingredients and we can't make them select all one by one
• if someone has an allergy then they will select it themselves only because it affects them
• for diet, not everyone has a choice and those who have a choice we already have a solution for them
• people might want to search something which they have never tried and if we have a long list of cuisines then that will also affect the search
• regarding holidays I am not sure how it works around the globe but a dish can't be specific to holidays

The only thing I can think of keeping as required is course but in that also we have two options(which according to me one is enough) and we are only going to display the cuisines that user wants, am I right? then why are we asking the user which cuisines they don't want

[chauhannishith]

https://ant.design/components/form/ contains validation example which we can use

[chauhannishith]

if you are thinking regarding hundreds of recepies that the server will bombard then we can do some stuff like google and only display one page at a time so that the load from server is also reduced and the user also only sees a few at a time