fix build with Sphinx 7.2 #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sphinx 7.2.3 restored the previous behaviour, thus it won't be noticed with many installations. |
funkyfuture
reviewed
Dec 23, 2023
Co-authored-by: Frank Sachsenheim <funkyfuture@users.noreply.github.com>
|
hey @MeggyCal and @funkyfuture! my apologies that this went by the board. given that this issue has been fixed in 7.2.3 and only affects the test suite, I'd like to close this PR without merging. I will, however, implement a small fix for the file names, given that for some reason I cannot push to the branch of @MeggyCal |
Chilipp
added a commit
that referenced
this pull request
Dec 28, 2023
see #88 Co-authored-by: Frank Sachsenheim <funkyfuture@users.noreply.github.com> Co-authored-by: MeggyCal <MeggyCal@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of Sphinx changed some output types, this tiny change was enough to run the tests with Sphinx 7.2.2.
I didn't build the docs, so I left the pin in
docs/requirements.txtas it is.