An option to sort sections #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks 😃 I'll have a closer look tomorrow. But yes, I agree that a simple |
Chilipp
requested changes
Jan 4, 2024
There was a problem hiding this comment.
hey @funkyfuture! thanks a lot for the input here! The changes look great! I only have two minor suggestions for the docs, but otherwise I am happy to merge this when you are done here and make a new release 👍
|
please let me know @funkyfuture if there is anything else from your side or if I can merge this PR as it is |
Co-authored-by: Philipp S. Sommer <philipp.sommer@hereon.de>
|
thanks for the feedback. i'm happy with the solution as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a solution for the proposal in #90.
from a user perspective, i'd actually rather prefer to simply provide aTrueto achieve simple alphabetical sorting. shall i extend to this?should i add an example where a dict with weights to define the order is used?i also did some occasional modernization of code as one may consider it. are these changes okay?