Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed source-generated class names #7819

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

CronKz
Copy link
Contributor

@CronKz CronKz commented Dec 10, 2024

  • Replace all special characters with an underscore
  • Ensure the first letter is either an underscore or letter

Closes #7801

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1b0e798). Learn more about missing BASE report.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7819   +/-   ##
=======================================
  Coverage        ?   74.31%           
=======================================
  Files           ?     2871           
  Lines           ?   149806           
  Branches        ?    17417           
=======================================
  Hits            ?   111333           
  Misses          ?    32672           
  Partials        ?     5801           
Flag Coverage Δ
unittests 74.31% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib changed the title Fix source-generated class names Fixed source-generated class names Dec 12, 2024
@michaelstaib michaelstaib merged commit 410d897 into ChilliCream:main Dec 12, 2024
3 checks passed
@michaelstaib michaelstaib added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Dec 12, 2024
@michaelstaib michaelstaib added this to the HC-14.3.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HotChocolate.Types.Analyzers generates invalid namespace in HotChocolateTypeModule.735550c.g.cs
2 participants