Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sockets for finding ip addresses. Closes #227 #228

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Use sockets for finding ip addresses. Closes #227 #228

merged 3 commits into from
Aug 18, 2023

Conversation

umesh-timalsina
Copy link
Contributor

No description provided.

edavalosanaya
edavalosanaya requested changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@edavalosanaya edavalosanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the ifaddr dependency first, then let's merge.

chimerapy/engine/utils.py Show resolved Hide resolved
@edavalosanaya edavalosanaya merged commit 7ffd165 into main Aug 18, 2023
3 checks passed
@edavalosanaya edavalosanaya deleted the 227-ip-addr-bug branch August 18, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edavalosanaya edavalosanaya edavalosanaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umesh-timalsina @edavalosanaya