Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up netscanner #42

Merged
merged 11 commits into from
Oct 20, 2024
Merged

Speed up netscanner #42

merged 11 commits into from
Oct 20, 2024

Conversation

zanderlewis
Copy link
Contributor

@zanderlewis zanderlewis commented Oct 18, 2024

This PR speeds up netscanner by removing tons of .clone() functions from various scripts. .clone() functions are replaced with references.

Note

My last PR was my first time contributing code to another project, so I wanted to see if I can do anything else for the project!

@Chleba
Copy link
Owner

Chleba commented Oct 18, 2024

Amazing work - Thanks a lot. I was planing that after some time spend with rust as part of some refactoring huge part of netscanner code.
Great that I have half of the job done :).

This PR may fix #11 by speeding up the process itself.

This is caused by concurrency problem that need to be refactored in discovery.rs code.

This PR speeds up netscanner

I think this will not speed up things that much, but it will not use that much memory - but I may need to be corrected on this one.

Copy link
Owner

@Chleba Chleba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work has been done from Your side @zanderlewis. Thank You very much.

src/components/discovery.rs Show resolved Hide resolved
src/components/discovery.rs Outdated Show resolved Hide resolved
src/components/discovery.rs Outdated Show resolved Hide resolved
src/components/discovery.rs Outdated Show resolved Hide resolved
src/components/packetdump.rs Outdated Show resolved Hide resolved
src/components/packetdump.rs Outdated Show resolved Hide resolved
src/components/wifi_scan.rs Outdated Show resolved Hide resolved
src/components/wifi_scan.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/tui.rs Outdated Show resolved Hide resolved
@Chleba
Copy link
Owner

Chleba commented Oct 18, 2024

My last PR was my first time contributing code to another project, so I wanted to see if I can do anything else for the project!

Just for next time - I would recommend to create a new branch in your fork for any other next PR's that You would like to make. When someone would like to try fix some conflict, it would be much better to see unique names on branches to better understand from where, what has been added and etc.

@Chleba Chleba added the enhancement New feature or request label Oct 18, 2024
Copy link
Owner

@Chleba Chleba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested everything and beside that after scanning some subnet the arrow is not showed in the table it's looking really good. I'll solve that in another commit so don't worry about that.
Thank you very much for your help. I really appreciate that.

@Chleba Chleba merged commit b351a56 into Chleba:main Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants