Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio projects and solutions target a specific Windows SDK version and platform toolset. This means that someone using a different version of Visual Studio will either have to retarget the project (and then revert the changes before checking in to source control) or download the required platform toolset and Windows SDK. Both options have drawbacks and neither is particularly necessary. In addition, this code uses no platform-specific constructs or APIs, so cross-platform capability is trivial.
I replaced the Visual Studio project files in this repository (not submodules) with CMake build files, made to closely match those in msdfgen's repo. In doing so, I noticed that you already have both Visual Studio and CMake build files, and I can modify the pull request to mirror this functionality if you'd prefer.
The top-level project adds
msdfgen
as a subdirectory and then builds and links against it. No additional setup is required..gitignore
has been modified to reflect the lack of top-level Visual Studio project files. I've successfully built this using Visual Studio 16 2019 (compiler version 16.6.2) on Windows and GCC 7.5.0 on Ubuntu WSL. On Linux systems where FreeType is already installed, it is detected automatically by CMake. On Windows, I found it necessary to manually specify the directory where FreeType is located.Thanks for reviewing this! Let me know if there are questions I can answer or changes you'd like me to make.