Display username in password-reset mail

[kimsible]

fixes #2954

[kimsible]

@rigelk I think it is a fix for an important issue because when the user receives the notification email, when can it be known the notification concerns the user's account ? For us, as developer, it's pretty obvious yes but for the user it could be blocking.

Plus displaying $[to] instead of a username is very confusing and seen as a bug.

[rigelk]

Yes - I'm just renaming because prefixing with "fix :" is not describing the content of the PR.

[kimsible]

Yes - I'm just renaming because prefixing with "fix :" is not describing the content of the PR.

Ok, it has nothing to do with the PR but is there a label to tag fixes ?

[rigelk]

For PRs, the determinant of its nature is the issue it solves, so using the fixes #.. syntax in the end of the description or as a "stamp" in a commit message helps determine that.

We use other labels to help us triage PRs (maintenance/priority), but not determine their fix/plain enhancement status.

[kimsible]

For PRs, the determinant of its nature is the issue it solves, so using the fixes #.. syntax in the end of the description or as a "stamp" in a commit message helps determine that.

We use other labels to help us triage PRs (maintenance/priority), but not determine their fix/plain enhancement status.

Thanks !

[rigelk]

The PR sounds good to me.

If you want to go forward with this idea, I would suggest adding to pretty much all emails the username and displayName as local variable. This would allow much richer links in the footer on the long term, but at first I would certainly see it used as follows:

replace the bland Hi, with Hi {username},. It would solve the current problem and more to come.

[kimsible]

replace the bland Hi, with Hi {username},. It would solve the current problem and more to come.

Hi {username} is already used in /server/lib/emails/common/greeting.pug

https://github.com/Chocobozzz/PeerTube/blob/develop/server/lib/emails/common/greetings.pug#L5

  if username
    p Hi #{username},
  else
    p Hi,

[rigelk]

Yes, I just meant to inject the variable in other email templates

[Chocobozzz]

Please use release/2.3.0 as base branch since it's a fix, so we can fix this issue in the next release