-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification sorting, users table flexible columns #2991
Conversation
a1c6a02
to
317116d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for channels search
client/src/app/+my-account/my-account-notifications/my-account-notifications.component.ts
Outdated
Show resolved
Hide resolved
@@ -41,9 +41,22 @@ const videoChannelsSearchValidator = [ | |||
} | |||
] | |||
|
|||
const videoChannelsOwnSearchValidator = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why OwnSearch
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there's already a videoChannelsSearchValidator
for public searches, which allows searchTarget
as query parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then videoChannelsListSearchValidator
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced
1. Sortable notifications Great! but on small and mobiles screens, we should adapt the 3 elements : 2. Flexible User listing It's a very cool feature @rigelk ! I love the way it really improve table handling ! When you select lots of column the last one become hidden cause to the scroll, so I ask the same question here, would it be good to put all actions including dropdown-actions on the left of user tables to avoid this ? |
5360f68
to
60979b7
Compare
41afa93
to
9d756c8
Compare
@rigelk a proposition sortable notifications : Mobile Small view : Update media queries in PeerTube/client/src/app/+my-account/my-account-history/my-account-history.component.scss Line 44 in 2e7f262
@media screen and (max-width: $mobile-view) {
.header {
flex-direction: column;
& >:first-child, .peertube-select-container {
margin-bottom: 15px;
}
.peertube-select-container {
margin-left: 0 !important;
}
}
}
@media screen and (min-width: $mobile-view) and (max-width: $small-view) {
.header {
a {
font-size: 0;
padding: 0 13px;
}
.peertube-select-container {
width: auto !important;
}
}
}
@media screen and (min-width: $mobile-view) and (max-width: #{$small-view + $menu-width}) {
:host-context(.main-col:not(.expanded)) {
.header {
a {
font-size: 0;
padding: 0 13px;
}
.peertube-select-container {
width: auto !important;
}
}
}
} |
Thanks for the snippet @kimsible, much appreciated 👍 |
9d756c8
to
2040dfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests
2040dfa
to
668fc7c
Compare
tests fail |
707b925
to
baeeae5
Compare
baeeae5
to
ba741de
Compare
This PR brings two unrelated changes:
Note: Sorry for the grouped PR - the past weeks have been hectic and I didn't find time to split the features in respective branches.