Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs/logs view select and empty state visual improvements #3127

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

rigelk
Copy link
Collaborator

@rigelk rigelk commented Aug 27, 2020

list of changes:

  • jobs view:
    • removed status column, since it is redundant with the above information
    • moved to the regular badge style
    • added empty state
    • added table pagination information and page size selector
  • logs view:
    • slightly improved startDate display
    • slightly improved level display

Screenshot_2020-08-27 Jobs - PeerTube(1)
Screenshot_2020-08-27 Logs - PeerTube

@rigelk rigelk added the UI non-trivial UI changes, that might need discussion label Aug 27, 2020
@kimsible
Copy link
Contributor

kimsible commented Aug 27, 2020

@rigelk, I only notice one thing related to the new ng-select and visible on this PR, the select inputs have wrong margins on small views :

image

You can just add ng-select into the scss component of logs :

For small views :

@media screen and (max-width: $small-view) {

@media screen and (max-width: $small-view) {
  .header {
    flex-direction: column;

    .peertube-select-container,
    ng-select, // new selector
    my-button {
      width: 100% !important;
      margin-left: 0px !important;
      margin-bottom: 10px !important;
    }

    my-button {
      text-align: center;
    }
  }
}

And for small views with opened menu :

@media screen and (max-width: #{$small-view + $menu-width}) {

@media screen and (max-width: #{$small-view + $menu-width}) {
  :host-context(.main-col:not(.expanded)) {
    .header {
      flex-direction: column;

      .peertube-select-container,
      ng-select,  // new selector
      my-button {
        width: 100% !important;
        margin-left: 0px !important;
        margin-bottom: 10px !important;
      }

      my-button {
        text-align: center;
      }
    }
  }
}

image

@rigelk
Copy link
Collaborator Author

rigelk commented Sep 28, 2020

thanks @kimsible!

@rigelk rigelk merged commit 7f0d856 into Chocobozzz:develop Sep 28, 2020
@rigelk rigelk deleted the jobs-visual branch September 28, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI non-trivial UI changes, that might need discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants