Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve markdown-it emoji list column display #3253

Merged
merged 2 commits into from
Nov 8, 2020

Conversation

kimsible
Copy link
Contributor

@kimsible kimsible commented Nov 5, 2020

Fix #3245

  • Use CSS flex instead of a classic table to extend the columns on the full modal width and make it responsive ;
  • Center the columns ;
  • Populate the the markdown-it emoji list from object to array to avoid an alphabetical order of the keys.

emoji-list
image

@rigelk rigelk self-assigned this Nov 6, 2020
@rigelk
Copy link
Collaborator

rigelk commented Nov 7, 2020

@kimsible is this ready for review?

@kimsible
Copy link
Contributor Author

kimsible commented Nov 7, 2020

@kimsible is this ready for review?

I think yes, because the flex percent solution looks to not be adapted to the longest markup names of emojis.

@rigelk rigelk changed the title Improve markdown-it emoji list display Improve markdown-it emoji list column display Nov 8, 2020
@rigelk rigelk merged commit f34cc2a into Chocobozzz:develop Nov 8, 2020
@rigelk
Copy link
Collaborator

rigelk commented Nov 8, 2020

@kimsible thanks for your quick response to the issue and sensible fix! Also thank you @test2a for your review.

fflorent pushed a commit to fflorent/PeerTube that referenced this pull request Dec 31, 2020
Co-authored-by: kimsible <kimsible@users.noreply.github.com>
Co-authored-by: Rigel Kent <sendmemail@rigelk.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markdown emoji list- one long list
3 participants