more explicit error messages for file uploads #3347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
File uploads are often met with network errors. They can also be met with classic HTTP errors as defined in our spec. Both are dealt with (reset + notification), but notification messages only last 5 seconds, and their messages are not always describing the code correctly nor left in the console for later investigation. Since users uploading large files or with unleliable connections are not always monitoring their upload page, they might miss a temporary notification.
This PR brings:
@Chocobozzz are you interested by the maximum file size information being given by the reverse-proxy, or is it superfluous?
Related issues
This issue is related to #324 (comment), and
fixes #3050
Has this been tested?