Allow users/visitors to search through an account's videos #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelk
force-pushed
the
account-search
branch
from
2fd5e05
to
90b33be
Compare
rigelk
force-pushed
the
account-search
branch
from
90b33be
to
e05b546
Compare
Chocobozzz
previously requested changes
Jan 13, 2021
client/src/app/shared/shared-main/misc/simple-search-input.component.html
Outdated
Show resolved
Hide resolved
client/src/app/+accounts/account-search/account-search.component.ts
Outdated
Show resolved
Hide resolved
Chocobozzz
added
Status: Requires Tests
rigelk
force-pushed
the
account-search
branch
from
e05b546
to
d0f5821
Compare
|
@Chocobozzz where should I place tests? I can’t find any existing tests for the accounts API (juste their validators). |
rigelk
removed
the
Status: Requires Tests
|
Please rebase from develop when the develop tests will be fixed. |
rigelk
force-pushed
the
account-search
branch
from
9455bf2
to
20e2dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a search icon that on click reveals a search input. Upon validating the search (pressing enter), a listing of videos is taken and filtered with the search terms.
Related issues
related to meta #3486
Has this been tested?
Screenshots