Merge pull request #1026 from comxd/master

Fix typo on aria-labelledby attribute
Choices-js · Apr 12, 2022 · 06d16cd · 06d16cd
2 parents 20d3f5c + 72da548
commit 06d16cd
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -615,7 +615,7 @@ const example = new Choices(element, {
 
 **Input types affected:** `select-one`, `select-multiple`
 
-**Usage:** The labelId improves accessibility. If set, it will add aria-labeledby to the choices element.
+**Usage:** The labelId improves accessibility. If set, it will add aria-labelledby to the choices element.
 
 ### classNames
 

diff --git a/public/types/src/scripts/interfaces/options.d.ts b/public/types/src/scripts/interfaces/options.d.ts
@@ -412,7 +412,7 @@ export interface Options {
      */
     fuseOptions: Fuse.IFuseOptions<Choices>;
     /**
-     * ID of the connected label to improve a11y. If set, aria-labeledby will be added.
+     * ID of the connected label to improve a11y. If set, aria-labelledby will be added.
      */
     labelId: string;
     /**

diff --git a/src/scripts/interfaces/options.ts b/src/scripts/interfaces/options.ts
@@ -454,7 +454,7 @@ export interface Options {
   fuseOptions: Fuse.IFuseOptions<Choices>;
 
   /**
-   * ID of the connected label to improve a11y. If set, aria-labeledby will be added.
+   * ID of the connected label to improve a11y. If set, aria-labelledby will be added.
    */
   labelId: string;
 

diff --git a/src/scripts/templates.test.ts b/src/scripts/templates.test.ts
@@ -95,7 +95,7 @@ describe('templates', () => {
               tabindex="0"
               aria-haspopup="true"
               aria-expanded="false"
-              aria-labeledby="${labelId}"
+              aria-labelledby="${labelId}"
               dir="${direction}"
               >
             </div>

diff --git a/src/scripts/templates.ts b/src/scripts/templates.ts
@@ -45,7 +45,7 @@ const templates = {
     div.setAttribute('aria-haspopup', 'true');
     div.setAttribute('aria-expanded', 'false');
     if (labelId) {
-      div.setAttribute('aria-labeledby', labelId);
+      div.setAttribute('aria-labelledby', labelId);
     }
 
     return div;