Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeActiveItems method - excludedId should be optional? #1116

Closed
beyer96 opened this issue Apr 28, 2023 · 1 comment
Closed

removeActiveItems method - excludedId should be optional? #1116

beyer96 opened this issue Apr 28, 2023 · 1 comment
Labels
bug

Comments

@beyer96
Copy link

beyer96 commented Apr 28, 2023

Hello,

not sure if this should be considered as bug (if not, sorry!), but I think removeActiveItems should take excludedId parameter as optional.

Correct me if I'm wrong, but I use this method with no parameter and no issues. Now, I have to use it with Typescript which yells at me that this method needs argument. I suppressed it of course, but it would be nice not have to do so :)

Thanks for any response!
@beyer96 beyer96 added the bug label Apr 28, 2023
This was referenced Aug 22, 2024
Closed
Closed
Closed
Closed
@Xon
Copy link
Collaborator

Xon commented Aug 22, 2024

That does make sense, and it is quite a small change. Implemented for the v11.0.0 release

@Xon Xon closed this as completed Aug 22, 2024
Xon added a commit to Xon/Choices.js that referenced this issue Aug 22, 2024
@Xon
Update typescript definition for removeActiveItems to explicitly ma…
9656844 
…rk `excludedId` as optional Choices-js#1116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xon @beyer96