Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for parameter on setChoiceByValue #1021

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Fix type for parameter on setChoiceByValue #1021

merged 1 commit into from
Mar 13, 2022

Conversation

mtriff
Copy link
Member

@mtriff mtriff commented Mar 13, 2022

Description

Fix type for parameter on setChoiceByValue to reflect that string[] are allowed. Fixes #1017.

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mtriff mtriff added the bugfix Pull request that fixes an existing bug label Mar 13, 2022
@mtriff mtriff merged commit 20d3f5c into master Mar 13, 2022
@Xon Xon deleted the fix-param branch August 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong parameter type for setChoiceByValue
1 participant