Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a variable for the z-index #794

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Adds a variable for the z-index #794

merged 1 commit into from
Dec 15, 2019

Conversation

dgrammatiko
Copy link
Contributor

Description

Just adding a variable for the z-index. It's easier to consume the default scss just by overriding some variables. At this point extending a class that has a predefined z-index requires a !important, which is unnecessary

Types of changes

SCSS, adding a variable, minor change

Checklist

  • [X ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dgrammatiko
Copy link
Contributor Author

Referring joomla/joomla-cms#27261

Copy link
Collaborator

@jshjohnson jshjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@jshjohnson jshjohnson added the housekeeping Pull request that improves code readability but maintains behaviour label Dec 13, 2019
@jshjohnson jshjohnson merged commit 3ed0272 into Choices-js:master Dec 15, 2019
@dgrammatiko
Copy link
Contributor Author

Thank you 🙏

@dgrammatiko dgrammatiko deleted the patch-1 branch December 15, 2019 19:27
@brianteeman
Copy link

any chance of a new release with this change as a xmas present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Pull request that improves code readability but maintains behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants