Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to typescript #795

Merged
merged 31 commits into from
Dec 23, 2019
Merged

Convert to typescript #795

merged 31 commits into from
Dec 23, 2019

Conversation

jshjohnson
Copy link
Collaborator

Description

Converts the whole library to TypeScript

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshjohnson jshjohnson added the WIP label Dec 14, 2019
@cypress
Copy link

cypress bot commented Dec 18, 2019



Test summary

107 13 0 2


Run details

Project Choices
Status Failed
Commit efb86d5
Started Dec 21, 2019 1:27 PM
Ended Dec 21, 2019 1:29 PM
Duration 02:07 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 73

View run in Cypress Dashboard ➡️


Failures

select-multiple.spec.js Failed
1 ... > removing choices > on backspace > removes last choice
2 ... > removing choices > on backspace > updates the value of the original input
3 ... > on click > removes respective choice
4 ... > selecting a disabled choice > does not select choice
5 ... > deselecting all choices in group > shows group in dropdown
select-one.spec.js Failed
1 ... > remove button > on click > removes selected choice
2 ... > selecting a disabled choice > does not change selected choice
3 ... > deselecting all choices in group > shows group in dropdown
text.spec.js Failed
1 ... > on back space > allows me to change my entry
2 ... > on cmd+a > highlights all items
This comment includes only the first 10 test failures. See all 13 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jshjohnson jshjohnson added chore Pull request that does not change core code and removed WIP labels Dec 23, 2019
@jshjohnson jshjohnson merged commit 68313da into master Dec 23, 2019
@jshjohnson jshjohnson deleted the convert-to-typescript branch December 23, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull request that does not change core code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant