Favourites are not in correct order if user has items and containers bookmarked #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… containers and single items, e.g. podcasts and radio stations. See Leonidas-from-XIV/node-xml2js#31 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement PR of old PR #48
Hello,
I found an issue with Favourites: If a user has bookmarked a mix of items and containers, the sorting of the favourites returned by raumkernel is not correct. This can e.g. happen if a user has bookmarked podcasts and radio stations.
The behaviour is related to this issue within xml2js: Leonidas-from-XIV/node-xml2js#31
I tried to create a fix, but I don't have many test scenarios at hand so please merge with care only and please review before merging :)
What do you think about the approach - can there be any side effects? Are there other places in code where a similar issue could appear?
I don't have a large media library to test, so I don't know if there could be any performance side effects of the new configuration to xml2js. (Most likely not)
Best,
Uli