Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for flathub management #341

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

kleidis
Copy link
Contributor

@kleidis kleidis commented Sep 11, 2024

Pull Request

Title

Initial support for flathub management

Type of Change

  • New feature
  • Bug fix
  • Documentation Update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

This PR adds a new folder on Application Setup tab that has 2 items related to flathub

  • Setup flatpak
    • Downloads flatpak package and adds the flathub remote
  • Uninstall flatpak
    • Uninstalls flathub and removes remote

Also updates flathub update on system update script

Testing

I confirm OpneSUSE TW and Ubuntu are working but also did earlier testing on Fedora and Arch which also worked

Impact

Easy setup of flathub remote for new users

Issue related to PR

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@nnyyxxxx
Copy link
Contributor

@kleidis TOO many bashisms in this; Linutil is supposed to be posix compliant, also duplicate of #339

@kleidis
Copy link
Contributor Author

kleidis commented Sep 11, 2024

@kleidis TOO many bashisms in this; Linutil is supposed to be posix compliant, also duplicate of #339

Removing the bashisms can be possible, but should I close this in favor of the other PR?

The way he implemented flathub setup, it isn't ideal
Edit: Seems he clsoed it

@nnyyxxxx
Copy link
Contributor

@kleidis TOO many bashisms in this; Linutil is supposed to be posix compliant, also duplicate of #339

Removing the bashisms can be possible, but should I close this in favor of the other PR?

The way he implemented flathub setup, it isn't ideal Edit: Seems he clsoed it

You should go over the scripts with the "checkbashisms" package to ward out all of them.

@kleidis
Copy link
Contributor Author

kleidis commented Sep 11, 2024

Since I might be busy, I'm converting it to a draft

@kleidis kleidis marked this pull request as draft September 11, 2024 17:21
@kleidis
Copy link
Contributor Author

kleidis commented Sep 12, 2024

Had to remove the download script because removing all bashisms while keeping the TUI proved to be challenging
Looks like this needs to be tackled directly with the rust code, which I am not willing to do RN

Not to mention the flathub API completely stopped working today for whatever reason while it was working fine yesterday, so it really doesn't seem like a good way of fetching flathub

@kleidis
Copy link
Contributor Author

kleidis commented Sep 12, 2024

@nnyyxxxx Mind rechecking?

@kleidis kleidis marked this pull request as ready for review September 12, 2024 16:30
@ChrisTitusTech
Copy link
Owner

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

@kleidis
Copy link
Contributor Author

kleidis commented Sep 12, 2024

First

@kleidis
Copy link
Contributor Author

kleidis commented Sep 13, 2024

All should be good now

@kleidis
Copy link
Contributor Author

kleidis commented Sep 13, 2024

As discussed on #362 , uninstall or revert scripts should not be separate entries

Once the revert_tweaks script is in place, i'll re-add the uninstall part of the script back
For now, it will be removed

@ChrisTitusTech ChrisTitusTech merged commit 6cd7818 into ChrisTitusTech:main Sep 19, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatpak & FlatHub setup
3 participants