Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add User Manager #393

Merged
merged 9 commits into from
Sep 19, 2024

Conversation

jeevithakannan2
Copy link
Contributor

Pull Request

User manager to create / modify users

Type of Change

  • New feature
  • Documentation Update

Description

Add a user manager script that can do the following

  • Create a new user

  • Delete a user

  • Modify a user

    • Change password
    • Add user to group
    • Remove user from group
  • Also added docs for utilities

Testing

  • Tested by adding removing modifying users.
  • If root user is modified only the password change is reflected in the system adding to group or removing from group shows successful message but it did not have any affect in the system.
  • Added a check if the user is trying to delete or modify a system user [ i.e Users created by apps, For example git has a user ]

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@guruswarupa
Copy link
Contributor

rename things to User Account Manager.

@jeevithakannan2 jeevithakannan2 marked this pull request as ready for review September 16, 2024 04:50
@guruswarupa
Copy link
Contributor

@jeevithakannan2 could you move these scripts to utils? + rename it to user account manager. whats user manager?

@jeevithakannan2
Copy link
Contributor Author

It must be under utility it is not an application or system setup. And it should've been user account manager not user manager

tabs/utils/test.sh Outdated Show resolved Hide resolved
@guruswarupa
Copy link
Contributor

guruswarupa commented Sep 16, 2024

It must be under utility it is not an application or system setup. And it should've been user account manager not user manager

that's exactly what i asked u to do.

@nnyyxxxx
Copy link
Contributor

@jeevithakannan2 Please unresolve those reviews, they are not resolved in the slightest.

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Sep 16, 2024

@jeevithakannan2 Please unresolve those reviews, they are not resolved in the slightest.

They are resolved

@nnyyxxxx
Copy link
Contributor

@jeevithakannan2 Check the comment I added in the review. I explained it more.

@jeevithakannan2
Copy link
Contributor Author

@jeevithakannan2 Check the comment I added in the review. I explained it more.

Added them like you wanted. not going to ague over this. Wasted my time on this crap

@jeevithakannan2
Copy link
Contributor Author

Don't ask to me squash the commits. I'm not going to do that !! Not going to waste my time on this again

@guruswarupa
Copy link
Contributor

guruswarupa commented Sep 16, 2024

@jeevithakannan2 we reviewers ask you to do certain things so that the script follows the uniformity as well as is free from bugs which could happen by not calling those functions. now squashing your commits is necessary because chris wont accept it when u have so many commits on such a small pr. if you dk how to, we'll teach you. dont worry.

@guruswarupa
Copy link
Contributor

guruswarupa commented Sep 16, 2024

@jeevithakannan2 open your fork in vs code. go to the respective branch where this is present. then, in terminal type git rebase -i HEAD~8 then using editor keep first one as pick, change rest from pick to s and save and exit. now another window will open. here remove all commit messages other than the first one. and again save and exit. and then type git push origin branchname --force

@github-actions github-actions bot added the enhancement New feature or request label Sep 18, 2024
@ChrisTitusTech ChrisTitusTech merged commit f64fa2b into ChrisTitusTech:main Sep 19, 2024
2 checks passed
@jeevithakannan2 jeevithakannan2 deleted the user-manipulation branch September 19, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants