Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Command Description #437

Merged
merged 3 commits into from
Sep 19, 2024
Merged

feat: Command Description #437

merged 3 commits into from
Sep 19, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 17, 2024 •
edited
Loading

Pull Request

Title

Implement command description for commands just like how command preview works

Type of Change

  • New feature

Description

Add command description be using D key just like how command preview works

about

Testing

Works as expected.

Impact

When new scripts are added a description must be added in the toml for command description to work

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

nnyyxxxx
nnyyxxxx reviewed Sep 17, 2024
View reviewed changes
tui/src/hint.rs Outdated Show resolved Hide resolved
nnyyxxxx
nnyyxxxx reviewed Sep 17, 2024
View reviewed changes
tui/src/state.rs Outdated Show resolved Hide resolved
nnyyxxxx
nnyyxxxx reviewed Sep 17, 2024
View reviewed changes
tui/src/float.rs Outdated Show resolved Hide resolved
@nnyyxxxx
Copy link
Contributor

Not sure why the keybind is "a" when "d" is the first letter of "description"

nnyyxxxx
nnyyxxxx approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Sep 17, 2024 •
edited
Loading

Not sure why the keybind is "a" when "d" is the first letter of "description"

It was initially thought to the function name as about page and the key A for about but command description suited it better so I refactored the function names to description with D as keybind

@nnyyxxxx
Copy link
Contributor

Not sure why the keybind is "a" when "d" is the first letter of "description"

It was initially thought to the function name as about page and the key A for about but command description suited it better so I refactored the function names to description with D as keybind

yeah thanks

@ChrisTitusTech
Copy link
Owner

Now this is PERFECT! Thank you @jeevithakannan2 exactly what I was thinking.

@ChrisTitusTech ChrisTitusTech merged commit a7e6ea0 into ChrisTitusTech:main Sep 19, 2024
3 checks passed
@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 19, 2024
@jeevithakannan2 jeevithakannan2 deleted the about-page branch September 21, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

@nnyyxxxx nnyyxxxx nnyyxxxx approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a box to linutil for a description of the program.
4 participants
@jeevithakannan2 @nnyyxxxx @ChrisTitusTech @adamperkowski