Fix missing escalation tool #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2024
5 tasks
nnyyxxxx
changed the title
adamperkowski
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with #442 #440 #454
Type of Change
Description
#422 does this slightly correct; I have added the missing ones that weren't included in his PR
Gaming-setup & Aur helpers were skipped due to #382 and #380 which include refactoring for both of these functionality
ONLY after I made my 3 PRs did he decide to implement MY fixes.. before: 61cddeb after: 100fc58
My commits are VERIFIED, meaning everything that I do contains MY work. Take a look at these 2 commits and decide for your self. The first commit contained INCOMPLETE functionality and only after making my 3 PRs that fixed those issues did he decide to grab the changes in my commits and then implement them in his.
Checklist