-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor various components of Rust code #490
Refactor various components of Rust code #490
Conversation
Merging #338 will create a conflict with this PR. I remember adding some comments in that one too. I am sorry I will clean up the mess later in a few minutes. |
Comments aren't a bad thing. Pointless comments that basically just state the name of the variable or exactly what an if statement is doing (i.e. I'll resolve the conflicts once that's merged, don't worry about it. |
Yeah thanks for your efforts @lj3954 . Like I was saying before, they were added because I was explaining my PRs to one of my friends who is a winutil fan by the way. He doesn't have a lot of coding knowledge. He understands the code base easily with more comments. I will clean out all the unwanted comments in a few minutes |
Added lj's thought process from ChrisTitusTech#490 Co-authored-by: Liam <33645555+lj3954@users.noreply.github.com>
Added lj's thought process from #490 Co-authored-by: Liam <33645555+lj3954@users.noreply.github.com>
Type of Change
Description
Refactor various functions to improve readability and remove duplicate code. Commits can be viewed individually for specific changes and some reasoning.
Testing
Functionality is identical to before; program does not crash.
Impact
No changes in functionality. Code is more maintainable.
Checklist