Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix for intel hd #2594

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

YusufKhalifadev
Copy link
Contributor

Pull Request

fixed low performance on intel hd

Title

intel hd graphics too slow on winutil

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

winutil was too slow on intel hd graphics

Testing

I tested it on my PC

Impact

fix this issue for intel hd users

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

fixed low performance on intel hd
@MyDrift-user
Copy link
Contributor

MyDrift-user commented Aug 20, 2024

hello @YusufKhalifadev, thanks for this PR
How about changing "*UHD*" to "*HD*", this way both would be integraded and keep it short, that way it is making sure everything where HD gets mentioned also get's added.

EDIT: This is probably not a good idea, look at mr-k's explanation.

@YusufKhalifadev
Copy link
Contributor Author

@MyDrift-user thanks for reporting sure we'll add it

@og-mrk
Copy link
Contributor

og-mrk commented Aug 20, 2024

hello @YusufKhalifadev, thanks for this PR
How about changing "*UHD*" to "*HD*", this way both would be integraded and keep it short, that way it is making sure everything where HD gets mentioned also get's added.

It might falsely detect Radeon HD graphics cards as low spec.. even though it should handle the GUI effects quite well.

Leaving it with the current changes proposed by this PR is better, IMHO.

@MyDrift-user
Copy link
Contributor

MyDrift-user commented Aug 20, 2024

Leaving it with the current changes proposed by this PR is better, IMHO.

don't really know about Radeon GPUs, but thanks for the imput.
@YusufKhalifadev, I suggest not doing the changes I've mentioned.

@YusufKhalifadev
Copy link
Contributor Author

YusufKhalifadev commented Aug 20, 2024

Leaving it with the current changes proposed by this PR is better, IMHO.

don't really know about Radeon GPUs, but thanks for the imput.
@YusufKhalifadev, I suggest not doing the changes I've mentioned.

Ok i'll leave it for now until chris streams

@ChrisTitusTech ChrisTitusTech merged commit 889ec8f into ChrisTitusTech:main Aug 29, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants