Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Disable Teredo to Advanced and Add prefer-ipv4 tweak #2633

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

Marterich
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix

Description

  • Move the "Disable Teredo" Tweak to advanced tweaks because of problems with XBOX Games and some other games that require the feature.
  • Add a new tweak that prioritises IPv4 over IPv6 to get pretty much the same latency and security upsides without actually disabling the feature as an essential tweak

Testing

Win11 Pro 23H2 VM

Impact

Users should experience fewer unexpected problems in the future

Issue related to PR

Additional Information

If I understand correctly, the dev docs links will be auto generated in the tweaks.json. If not, let me now or fix it yourself :)

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.

config/tweaks.json Outdated Show resolved Hide resolved
@MyDrift-user
Copy link
Contributor

MyDrift-user commented Aug 28, 2024

Since it currently does not seem to be hooked up to any workflow it will not autogenerate. I suggest running the autodocs generator again and then the link should be the correct one already.

EDIT: I just reviewed an outdated commit, please ignore this message

@og-mrk
Copy link
Contributor

og-mrk commented Aug 28, 2024

@Marterich The link are autogenerated from devdocs-generator.ps1. Since it currently does not seem to be hooked up to any workflow it will not autogenerate. I suggest running the autodocs generator again and then the link should be the correct one already.

EDIT: Note that this only has to be done because the script is not yet connected to a workflow

This was already addressed in this review comment, and how it works was briefly explained in this review comment, and yes.. currently the autodocs doesn't get run.. it should get ran after PR merges, which's better than after each commit done by PR author (in the Compile & test workflow), plus we can agree that the script is pretty stable, haven't notice any major problems with it, so committing changes made by the script is reasonable enough (at least IMO).

@ChrisTitusTech
Copy link
Owner

Thanks @Marterich I agree with this tweak as I have seen some downside to Teredo as well. In the future I might remove Teredo all together as I don't see a scenario where disabling it would be better than the prioritization method.

@ChrisTitusTech ChrisTitusTech merged commit 9ae5092 into ChrisTitusTech:main Aug 28, 2024
1 check passed
@Marterich Marterich deleted the teredo-ipv4/6 branch August 30, 2024 15:40
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant play overwatch since teredo is disabled. Cant reenable it
4 participants