-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Disable Teredo to Advanced and Add prefer-ipv4 tweak #2633
Conversation
Since it currently does not seem to be hooked up to any workflow it will not autogenerate. I suggest running the autodocs generator again and then the link should be the correct one already. EDIT: I just reviewed an outdated commit, please ignore this message |
This was already addressed in this review comment, and how it works was briefly explained in this review comment, and yes.. currently the autodocs doesn't get run.. it should get ran after PR merges, which's better than after each commit done by PR author (in the Compile & test workflow), plus we can agree that the script is pretty stable, haven't notice any major problems with it, so committing changes made by the script is reasonable enough (at least IMO). |
Thanks @Marterich I agree with this tweak as I have seen some downside to Teredo as well. In the future I might remove Teredo all together as I don't see a scenario where disabling it would be better than the prioritization method. |
Type of Change
Description
Testing
Win11 Pro 23H2 VM
Impact
Users should experience fewer unexpected problems in the future
Issue related to PR
Additional Information
If I understand correctly, the dev docs links will be auto generated in the tweaks.json. If not, let me now or fix it yourself :)
Checklist