Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small patches for main.ps1 script #2640

Merged

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Aug 28, 2024

Type of Change

  • Hotfix

Description

  • Changing the order of operation in main.ps1 script, where it'll check if XAML parsing was successful or not, before continuing on with UI Dynamic Generation. ( commit 32877fe )
  • Use Write-Host instead of Write-Warning or even Write-Error because it can be ignored sometimes because of Runspaces and older ps shell environments (e.g. PowerShell 5). ( commit 0c4c483 )

Testing

tested the changes, and everything works as intended.

Impact

It'll fail fast/gracefully upon unsuccessful parsing of XAML, which'll speedup development a bit (not that much, but it can add up overtime), beside that it won't effect End Users.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

…ake sure the output is seen in different environments

This'll make sure that the output is displayed in PowerShell 5 developing environments, and when outputing Warnings/Errors in Runspaces.
@ChrisTitusTech ChrisTitusTech merged commit 9787634 into ChrisTitusTech:main Aug 28, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
@og-mrk og-mrk deleted the small-patches-for-main-script branch September 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants