Fix the configuration file import feature in the Invoke-WPFImpex function #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Cryostrixx, thanks for adressing this. I found a matching issue, which is related to this PR, may you please add "closes #2657" to the description so it will be closed on merge? |
Apologies for the oversight. Just to confirm, should I use |
|
No issue, could happen to everyone, to answer the question: the quotes are not needed |
Perfect, it’s added now. I also cleaned up the PR message a bit. Thanks for pointing that out! |
Cryostrixx
changed the title
Cryostrixx
changed the title
Real-MullaC
approved these changes
Sep 2, 2024
ChrisTitusTech
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Fix the configuration file import feature in the Invoke-WPFImpex function
Type of Change
Description
This PR addresses an issue with the
Invoke-WPFImpexfunction inwinutil.ps1.Recent changes to
Invoke-WPFImpexrequire explicit string conversion for the$flattenedJsonparameter.The conversion was previously handled implicitly, but it now needs to be explicitly converted to ensure correct processing.
Testing
$flattenedJsonparameter is now correctly processed as a string.Impact
$flattenedJsonparameter is handled correctly as a string, preventing errors during configuration imports.Issues related to PR
Additional Information
Screenshots
Before Fix
After Fix
Checklist