Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MicroWin] Don't disable already disabled features #2675

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

CodingWonders
Copy link
Contributor

@CodingWonders CodingWonders commented Sep 4, 2024

Pull Request

Type of Change

  • New feature

Description

This PR excludes features that are already disabled in the image. It's nothing but a timesaver, especially for less powerful systems:

powershell_ih7o6evZgx

EDIT: Some (raw) benchmarks of the latest version and the one with this change:

  • Latest Version: 51:17.55
  • This PR: 39:07.56

The benchmarks were performed on a dual-core system, with a couple of applications running. The time taken was measured manually. These values are subject to change depending on your hardware or software configuration.

Testing

Testing was performed on a Windows 11 23H2 image and concluded with no issues. No differences were present across the current method and this one after grabbing the feature listings. Below are the actual differences of both reports:

Code_DdMh48qRcv

  • experimental_features_report.md contains feature listings of a Windows image after running a MicroWin experiment with package listings reversed, but with no changes to feature disablement
  • timesaver_features_report.md contains feature listings of a Windows image after running this change

Impact

Less time to be spent disabling features

Issue related to PR

None

Additional Information

No documentation changes were necessary, but please test this for any issues present that I may not know of

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@ChrisTitusTech ChrisTitusTech merged commit 95db85f into ChrisTitusTech:main Sep 10, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants