Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH server option #2745

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

SSH server option #2745

wants to merge 14 commits into from

Conversation

xicor22
Copy link
Contributor

@xicor22 xicor22 commented Sep 15, 2024

Type of Change

  • New feature

Description

Most winutil users are power users and most probably use ssh to remote into their other machine so I created this PR to add an option to enable ssh server.

Testing

  • Win 11

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

commit c674d5e
Author: Saksham Singh <sakshamsingh.93502@gmail.com>
Date:   Wed Sep 11 19:34:44 2024 +0530

    desc update

commit 3d8bf2b
Author: Saksham Singh <sakshamsingh.93502@gmail.com>
Date:   Wed Sep 11 19:30:23 2024 +0530

    Added Razer Block

    Added the razer block by chris titus under the Fixes Section
@MyDrift-user
Copy link
Contributor

Hey @xicor22, thanks for the PR

You did this change on the same branch as the other one, meaning both additions are in both PRs. Could you devide them by using diffrent branches please?

@xicor22
Copy link
Contributor Author

xicor22 commented Sep 15, 2024

Yea, i finally understand what i did wrong. Will make the changes soon. I'm new to the code contribution side of github 😅

@MyDrift-user
Copy link
Contributor

No issue, thanks in advance :)

@xicor22 xicor22 reopened this Sep 15, 2024
@xicor22
Copy link
Contributor Author

xicor22 commented Sep 15, 2024

@MyDrift-user I removed the #2715 changes from this PR. PLease let me know if I need to change anything else.

auth key file was not being created due to incomplete file path from the $env:HOMEPATH and also corrected the ssh directory to .ssh
Copy link
Contributor

@ruxunderscore ruxunderscore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straight forward. I like this addition. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants