Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac(invoke-wpffeatureinstall.ps1): simplify taskbaritem invocation #2799

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

momcilovicluka
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Refactor: functions/public/Invoke-WPFFeatureInstall.ps1

  • Simplify code and make it shorter

Testing

Not needed

Impact

Make code shorter and easier to read

Issue related to PR

  • Resolves #

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@momcilovicluka momcilovicluka changed the title refac(invoke-wpffeatureuninstall.ps1): simplify taskbaritem invocation refac(invoke-wpffeatureinstall.ps1): simplify taskbaritem invocation Sep 23, 2024
Copy link
Contributor

@ruxunderscore ruxunderscore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change. Looks like it should do the job. I wouldn't say it's any easier to read over the previous code, but it does shorten it.

@momcilovicluka
Copy link
Contributor Author

Thanks for the review. My goal was to make it shorter/easier to read/remove duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants