Use here-strings for JSON in Compile.ps1 #2816
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change Compile.ps1 to use here-strings with JSON, similar to my changes to Xaml being ingested using here-strings.
- Modifications, allowing for the removal of all .replace() functions in JSON handler. - Changed formatting of here-string on line 91 -> 89 to prevent accidental double in winutil.ps1 (Doesn't cause an issue, but looks better.) - Added here-string to 95 -> 93 (This allowed the removal of the final .replace())
- Added comment to line 90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I recommend going through my commits to see the changes I made over time, to better understand why I coded things the way I did.
Change Compile.ps1 to use here-strings with JSON.
Type of Change
Description
This modifies the Compile.ps1 script's handling of JSON to use here-strings and
-Raw, similar to what we do with Xaml. This allows us to forego the replace when weConvertTo-Json -Depth 3.There are a couple formatting to CamelCasing changes for consistency, as well.
Testing
Tested the Compile in pwsh and powershell (pulled in changes from @og-mrk for Pre-processing for testing in PS5.)
Checklist