Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LspDiagnosticsDefaultError highlight name #9

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Update LspDiagnosticsDefaultError highlight name #9

merged 2 commits into from
Nov 15, 2020

Conversation

caheredia
Copy link
Contributor

What

This PR updates Diagnostic Error highlight name.

As discussed in the diagnostic-nvim PR,

For example, the highlight that was formerly LspDiagnosticsError is now LspDiagnosticsVirtualTextError. It can also be configured by changing the default highlight group, LspDiagnosticsDefaultError. For more information, read :help lsp-highlight-diagnostics

Why

Diagnostic errors should also use Nord theme.

ChristianChiarulli
ChristianChiarulli approved these changes Nov 15, 2020
View reviewed changes
Copy link
Owner

@ChristianChiarulli ChristianChiarulli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@ChristianChiarulli ChristianChiarulli merged commit 30add1f into ChristianChiarulli:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianChiarulli ChristianChiarulli ChristianChiarulli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caheredia @ChristianChiarulli