Update Read.py #407
Closed
Update Read.py #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping version
auth token...
In readMultiple()-calls with "show_property_name=True" for standard/registered objects with proprietary/non-registered properties (which can be manually made with "@prop_<INT>" OR get in there automatically with the "all" keyword), there will be a TypeError thrown for line 384 in Read.py, because bacpypes won't find the proprietary property in the registered object. To fix this, there is now a check implemented to skip that search for the proprietary properties of a standard/registered object_type.
Also for all read()- and readMultiple()-calls, there were unconcise dictionaries returned. They are created by the cast_datatype_from_tag()-function, that gets called on proprietary/non-registered objects (datatype unknown). To streamline outputs, it is enough to make both read() and readMultiple() rework that dictionary to extract only the actual value of the proprietary property. Now, calls to read() and readMultiple() WITHOUT AND WITH "show_property_name" will show proprietary values like standard ones.
|
This pull request has not been processed yet, please proceed or close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I am working on BACnet controllers that implement objects with standard object types, but are "enhanced" by proprietary properties.
In readMultiple()-calls with "show_property_name=True" for those standard/registered objects with proprietary/non-registered properties (which can be manually made with "@prop_" OR get in there automatically with the "all" keyword), there will be a TypeError thrown for line 384 in Read.py, because bacpypes won't find the proprietary property in the registered object.
To fix this, there is now a check implemented to skip that search for the proprietary properties of a standard/registered object_type.
This will make readMultiple() return all standard and proprietary properties of "enhanced" standard objects correctly.