Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies and php-apache image. #54

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Remove unused dependencies and php-apache image. #54

merged 2 commits into from
Jul 18, 2023

Conversation

markdorison
Copy link
Contributor

@markdorison markdorison commented Jul 17, 2023 •
edited
Loading

Description

  • Removed php-apache image in favor of php-apache-node.
  • Removed unused python dependencies.

Motivation / Context

  • Builds of php-apache were breaking.
  • We have been switching to use php-apache-node in favor of php-apache. Let's complete that transition.
  • As far as I know, we no longer use the python dependencies on our projects.

Testing Instructions / How This Has Been Tested

Images build successfully.

@markdorison markdorison self-assigned this Jul 17, 2023
@markdorison markdorison force-pushed the remove-python-dependencies branch from 3fca051 to 940b0f5 Compare July 17, 2023 21:09
@markdorison markdorison changed the title Remove unused dependencies. Remove unused dependencies and php-apache image. Jul 17, 2023
@markdorison markdorison marked this pull request as ready for review July 17, 2023 21:15
@markdorison markdorison requested a review from agarzola July 17, 2023 21:15
@markdorison markdorison mentioned this pull request Jul 17, 2023
Closed
agarzola
agarzola approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@agarzola agarzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! :shipit:

@markdorison markdorison merged commit be79652 into main Jul 18, 2023
@markdorison markdorison deleted the remove-python-dependencies branch July 18, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarzola agarzola agarzola approved these changes

Assignees

@markdorison markdorison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdorison @agarzola