Remove opcache install as it is now included in the upstream image. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotek
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
This looks good. Not sure whether tugboatqa rebuilds their images on every merge, so we might want to confirm that their latest images include this before we merge.
Their builds are running right now. Should be done by end of day.
Once these two pages no longer say "5 days ago" we should be good to merge this.
https://hub.docker.com/r/tugboatqa/php
https://hub.docker.com/r/tugboatqa/php-nginx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove opcache install as it is now included in the upstream image.
Motivation / Context
TugboatQA/images#125
Testing Instructions / How This Has Been Tested
TBD