Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PHP 7.4 and 8.0. #73

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Deprecate PHP 7.4 and 8.0. #73

merged 1 commit into from
Feb 14, 2024

Conversation

markdorison
Copy link
Contributor

@markdorison markdorison commented Dec 21, 2023 •
edited
Loading

Description

Deprecate PHP 7.4 and 8.0.

Motivation / Context

Closes #72

Testing Instructions / How This Has Been Tested

  • I reviewed all of our repos that use these images and identified none that are still relying on PHP 7.4 or 8.0.
  • Tests are passing.

@markdorison markdorison self-assigned this Dec 21, 2023
@markdorison markdorison marked this pull request as ready for review December 21, 2023 14:41
@markdorison markdorison changed the title Deprecate PHP 7.4 and 8.1. Deprecate PHP 7.4 and 8.0. Dec 21, 2023
@markdorison markdorison requested a review from agarzola January 2, 2024 22:28
agarzola
agarzola approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@agarzola agarzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I missed this! This PR looks great to me. We very recently switched Poets.org to use one of our images (it was previously using a Tugboat image directly), but it’s on 8.1, so we’re covered here.

@markdorison markdorison merged commit 32ee4fd into main Feb 14, 2024
8 checks passed
@markdorison markdorison deleted the 72-deprecate-php-versions branch February 14, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarzola agarzola agarzola approved these changes

Assignees

@markdorison markdorison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate PHP 7.4 and 8.0 from image builds.
2 participants
@markdorison @agarzola