Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rector config. #146

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Update Rector config. #146

merged 3 commits into from
Jun 22, 2023

Conversation

markdorison
Copy link
Contributor

@markdorison markdorison commented Jun 22, 2023

Description

  • Update rector config.
  • Ignore troublesome rule temporarily.
  • Apply fixes.

Motivation / Context

Kepp all tests passing.

Testing Instructions / How This Has Been Tested

Tests pass.

@markdorison markdorison self-assigned this Jun 22, 2023
@ghost
Copy link

ghost commented Jun 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@markdorison markdorison changed the title Rename scripts. Update Rector config. Jun 22, 2023
@markdorison markdorison marked this pull request as ready for review June 22, 2023 16:40
@markdorison markdorison added the backport 2.x will automatically create backport PR to the 2.x branch when merged label Jun 22, 2023
Copy link
Contributor

@adamzimmermann adamzimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@markdorison markdorison merged commit 1c387f4 into 3.x Jun 22, 2023
@markdorison markdorison deleted the rename-scripts branch June 22, 2023 20:27
@github-actions
Copy link

Backport failed for 2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.x
git worktree add -d .worktree/backport-146-to-2.x origin/2.x
cd .worktree/backport-146-to-2.x
git checkout -b backport-146-to-2.x
ancref=$(git merge-base 45a913c0687b91a52781dd78b47a0ae89f4be097 018e133ec55b363f61a5feb37fbefda05b35402b)
git cherry-pick -x $ancref..018e133ec55b363f61a5feb37fbefda05b35402b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x will automatically create backport PR to the 2.x branch when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants