Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force a cache rebuild after a database refresh #221

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

apotek
Copy link
Contributor

@apotek apotek commented Sep 16, 2024

A cache rebuild forces a full bootstrap and any new code that relies on an unenabled module will fail the build.

Resolves #220

A cache rebuild forces a full bootstrap and any new
code that relies on an unenabled module will fail the
build.

Resolves #220
@apotek apotek requested a review from mmatsoo September 16, 2024 16:31
@apotek apotek self-assigned this Sep 16, 2024
@apotek apotek requested a review from mattdaniel September 16, 2024 16:36
Copy link
Member

@mmatsoo mmatsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mmatsoo
Copy link
Member

mmatsoo commented Sep 16, 2024

I only wonder if a cache rebuild should run in a separate step...so that it's still done, but not tied to the DB import.

Copy link

@mattdaniel mattdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apotek apotek merged commit 01507e0 into 4.x Sep 26, 2024
5 checks passed
@apotek apotek deleted the 220-tugboat-no-cache-rebuild branch September 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants