Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code climate rating #26

Closed
Cielquan opened this issue Feb 5, 2021 · 1 comment · Fixed by #27
Closed

Increase code climate rating #26

Cielquan opened this issue Feb 5, 2021 · 1 comment · Fixed by #27

Comments

@Cielquan
Copy link
Owner

Cielquan commented Feb 5, 2021

Feature request

The code climate rating is currently at B and it lists 7 code smells, which could be fixed.
@Cielquan
Copy link
Owner Author

Cielquan commented Feb 6, 2021

Update cc config:

  • argument-count: 4 -> 6
  • file-lines: 250 -> 500
  • identical-code: unknown -> 8
  • method-complexity: 5 -> 10
  • similar-code: unknown -> 4

@Cielquan Cielquan mentioned this issue Feb 6, 2021
Merged
2 tasks
Cielquan added a commit that referenced this issue Feb 6, 2021
@Cielquan
Merge branch 'main' into #26-increase-cc-rating
79103ca
Cielquan added a commit that referenced this issue Feb 6, 2021
@Cielquan
Merge pull request #27 from Cielquan/#26-increase-cc-rating
cae6cc0 
#26 increase cc rating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#26 increase cc rating Cielquan/formelsammlung
1 participant
@Cielquan