Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactored code to pass RC009 check #46

Merged
merged 4 commits into from
Jun 24, 2022

Conversation

ryanbourdais
Copy link
Contributor

This pull request should close issue #37

Refactored the commands that were longer than 64 characters into their own .sh files in a separate scripts directory found under ./src/scripts

@ryanbourdais ryanbourdais requested a review from a team as a code owner June 23, 2022 20:56
Copy link
Contributor

@JalexChen JalexChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would get a second check just in case since i'm not primarily orbs, but this looks good to me. everything looks so clean now :D

@FelicianoTech FelicianoTech requested review from FelicianoTech and a team June 24, 2022 07:11
@FelicianoTech FelicianoTech requested a review from a team June 24, 2022 07:12
@KyleTryon KyleTryon changed the title Refactor: Refactored code to pass RC009 check refactor: Refactored code to pass RC009 check Jun 24, 2022
Copy link

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@ryanbourdais ryanbourdais merged commit 296c2d7 into main Jun 24, 2022
@ryanbourdais ryanbourdais deleted the refactor-include-rc009 branch June 24, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include RC009 in the review step inside the "config.yml"
4 participants