Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Include link to Android machine tags list #59

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

Jaryt
Copy link
Contributor

@Jaryt Jaryt commented Dec 3, 2022

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

The tag is required, and it was unclear where to find it.

Description

Updated machine executor tag parameter description with dev hub link.
Also removed the reference to preview status archived repository

also removed the reference to an archived repository
@Jaryt Jaryt requested review from a team as code owners December 3, 2022 00:30
FelicianoTech
FelicianoTech previously approved these changes Dec 3, 2022
Copy link
Contributor

@FelicianoTech FelicianoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@JalexChen
Copy link
Contributor

ryan's sample project is blocking tests - however, the changes in this PR do not actually affect orb functionality and would not be in a release until later. i can try to fix up the google-play deploy process in a separate PR so we aren't relying on his keys, which might have been deleted

@JalexChen JalexChen merged commit 94ca73d into main Dec 13, 2022
@JalexChen JalexChen deleted the docs/machine-example branch December 13, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants