Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added background to create-avd #65

Merged
merged 3 commits into from
Feb 21, 2023
Merged

feat: added background to create-avd #65

merged 3 commits into from
Feb 21, 2023

Conversation

ryanbourdais
Copy link
Contributor

Added the ability to run create-avd in background, moved all run steps of create-avd.yml into the create-avd.sh file, and fixed the test-fastlane step of the test-deploy config. This should close #63

@ryanbourdais
feat: added background param to create-avd
3c1d0ad
@ryanbourdais
fix: fixed test-fastlane
9e21b66 
test

lint fix

added test step

rewrote test to be more clear

test

test

test

test

test

test

test

test

test

test

test

test

test

test

test

fix removed eval

removed old install step
@ryanbourdais ryanbourdais requested a review from a team as a code owner February 16, 2023 21:34
@ryanbourdais ryanbourdais mentioned this pull request Feb 16, 2023
Closed
FelicianoTech
FelicianoTech previously approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@FelicianoTech FelicianoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but would like a review by Jeff as well.

@ryanbourdais
Copy link
Contributor Author

I should note that the fastlane test fix simply changes the command that fastlane runs, so it prevents the orb tests from failing. Long term I need to decide whether to fix the true automation of the deployments on the sample app and add a test for that.

JalexChen
JalexChen reviewed Feb 17, 2023
View reviewed changes
src/commands/create-avd.yml Outdated Show resolved Hide resolved
.circleci/test-deploy.yml Show resolved Hide resolved
@ryanbourdais ryanbourdais merged commit b9c7773 into main Feb 21, 2023
@ryanbourdais ryanbourdais deleted the feat-add-background-to-create-avd branch February 21, 2023 17:10
@Whitespace Whitespace mentioned this pull request Mar 8, 2023
Closed
@Nisim761
Copy link

Nisim761 commented May 3, 2023

Added the ability to run create-avd in background, moved all run steps of create-avd.yml into the create-avd.sh file, and fixed the test-fastlane step of the test-deploy config. This should close #63

Thank you for implementing this so quickly. How can run the create-avd command in the background?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JalexChen JalexChen JalexChen approved these changes

@FelicianoTech FelicianoTech FelicianoTech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to create AVD in the background results in failure
4 participants
@ryanbourdais @Nisim761 @FelicianoTech @JalexChen