Merge pull request #15 from CircleCI-Public/fix_build

Fix build and example due to webhook-endpoint param type change
CircleCI-Public · Oct 10, 2019 · 2e505c6 · 2e505c6
2 parents b7db623 + c76901c
commit 2e505c6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -259,7 +259,6 @@ jobs:
           command: |
             spin application list
       - spinnaker/trigger-pipeline-with-webhook:
-          webhook-endpoint: "http://localhost:8084/webhooks/webhook/myappwebhook"
           payload: "{\\\"status\\\": \\\"success\\\", \\\"jobid\\\": \\\"$CIRCLE_WORKFLOW_JOB_ID\\\", \\\"message\\\": \\\"I've got it\\\"}"
       - spinnaker-test/verify-pipeline-execution:
           app-name: myapp

diff --git a/README.md b/README.md
@@ -59,6 +59,8 @@ jobs:
       # Send a request to a webhook endpoint pre-configured in Spinnaker
       # Ref: https://www.spinnaker.io/guides/user/pipeline/triggers/webhooks/
       - spinnaker/trigger-pipeline-with-webhook:
+          # Example env var value: "http://localhost:8084/webhooks/webhook/myappwebhook"
+          webhook-endpoint: SPINNAKER_WEBHOOK
           payload: "{\\\"status\\\": \\\"success\\\", \\\"jobid\\\": \\\"$CIRCLE_WORKFLOW_JOB_ID\\\", \\\"message\\\": \\\"I've got it\\\"}"
 workflows:
   example-workflow:

diff --git a/src/examples/trigger-pipeline-with-webhook.yml b/src/examples/trigger-pipeline-with-webhook.yml
@@ -36,7 +36,8 @@ usage:
         # Send a request to a webhook endpoint pre-configured in Spinnaker
         # Ref: https://www.spinnaker.io/guides/user/pipeline/triggers/webhooks/
         - spinnaker/trigger-pipeline-with-webhook:
-            webhook-endpoint: "http://localhost:8084/webhooks/webhook/myappwebhook"
+            # Example env var value: "http://localhost:8084/webhooks/webhook/myappwebhook"
+            webhook-endpoint: SPINNAKER_WEBHOOK
             payload: "{\\\"status\\\": \\\"success\\\", \\\"jobid\\\": \\\"$CIRCLE_WORKFLOW_JOB_ID\\\", \\\"message\\\": \\\"I've got it\\\"}"
   workflows:
     example-workflow: