Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use webhook enpoint value from ENV #14

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Use webhook enpoint value from ENV #14

merged 1 commit into from
Oct 9, 2019

Conversation

artplan1
Copy link
Contributor

@artplan1 artplan1 commented Oct 8, 2019

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Fixes #7

Description

Questions

  • added check for parameter, but not able to test it locally without custom bash scripts, ideas?
  • added webhook env variable name as SPINNAKER_WEBHOOK, not sure if it fits for you

KyleTryon
KyleTryon approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated!

@KyleTryon KyleTryon merged commit b7db623 into CircleCI-Public:master Oct 9, 2019
@artplan1 artplan1 deleted the webhook-enpoint-env branch October 10, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleTryon KyleTryon KyleTryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mask webhook by utilizing env_var_name parameter type
2 participants
@artplan1 @KyleTryon