Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dockerize timeout when Gate pod root endpoint is authenticated #17

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Fix dockerize timeout when Gate pod root endpoint is authenticated #17

merged 2 commits into from
Jan 7, 2020

Conversation

lokst
Copy link
Contributor

@lokst lokst commented Jan 6, 2020

Addresses #16 by accessing a different endpoint to determine pod readiness

@lokst
address #16 by
1c7519d 
letting dockerize use a different url that doesn't return 403
@lokst
don't use /health endpoint for Deck pod as it's inaccessible
a1a8454
@lokst lokst requested a review from a team January 6, 2020 07:53
@lokst lokst changed the title Fix dockerize timeout when Gate pod endpoint is authenticated Fix dockerize timeout that happens when Gate pod root endpoint is authenticated Jan 6, 2020
@lokst lokst changed the title Fix dockerize timeout that happens when Gate pod root endpoint is authenticated Fix dockerize timeout when Gate pod root endpoint is authenticated Jan 6, 2020
KyleTryon
KyleTryon approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lokst lokst merged commit 74ffc8e into master Jan 7, 2020
@lokst lokst deleted the fix-dockerize-timeout branch January 7, 2020 03:31
@lokst lokst added this to the 0.3.1 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleTryon KyleTryon KyleTryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lokst @KyleTryon