Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of NDO module for IPSLA Monitoring Policy (DCNE-135) #531

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Addition of NDO module for IPSLA Monitoring Policy (DCNE-135) #531

merged 1 commit into from
Dec 12, 2024

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Sep 12, 2024

No description provided.

@shrsr shrsr self-assigned this Sep 12, 2024
@shrsr shrsr linked an issue Sep 12, 2024 that may be closed by this pull request
Enhancement: New module for IPSLA Monitoring Policy in Tenant Tenant Policies Template (DCNE-135) #461
Closed
@shrsr shrsr changed the title Addition of NDO module for IPSLA Monitoring Policy Addition of NDO module for IPSLA Monitoring Policy (DCNE-135) Sep 12, 2024
@shrsr shrsr requested a review from akinross September 24, 2024 17:33
@shrsr shrsr requested a review from sajagana October 2, 2024 21:59
@shrsr shrsr requested a review from gmicol October 3, 2024 16:35
sajagana
sajagana previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmicol
gmicol previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr dismissed stale reviews from gmicol and sajagana via 915465f October 4, 2024 20:02
anvitha-jain
anvitha-jain previously approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross requested changes Oct 7, 2024
View reviewed changes
plugins/modules/ndo_ipsla_monitoring_policy.py Show resolved Hide resolved
plugins/modules/ndo_ipsla_monitoring_policy.py Show resolved Hide resolved
plugins/modules/ndo_ipsla_monitoring_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ipsla_monitoring_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ipsla_monitoring_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ipsla_monitoring_policy.py Outdated Show resolved Hide resolved
tests/integration/targets/ndo_ipsla_monitoring_policy/tasks/main.yml Outdated Show resolved Hide resolved
plugins/modules/ndo_ipsla_monitoring_policy.py Show resolved Hide resolved
plugins/modules/ndo_ipsla_monitoring_policy.py Show resolved Hide resolved
@shrsr shrsr requested a review from samiib December 5, 2024 14:34
sajagana
sajagana previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shrsr shrsr requested review from sajagana and akinross December 6, 2024 16:43
samiib
samiib previously approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr dismissed stale reviews from gmicol and samiib via c80387f December 9, 2024 15:30
@shrsr shrsr requested review from gmicol and samiib December 9, 2024 15:30
samiib
samiib approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmicol
gmicol approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 947e1ba into CiscoDevNet:master Dec 12, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@sajagana sajagana sajagana approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@akinross akinross akinross approved these changes

@lhercot lhercot lhercot approved these changes

Assignees

@shrsr shrsr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for IPSLA Monitoring Policy in Tenant Tenant Policies Template (DCNE-135)
7 participants
@shrsr @lhercot @akinross @anvitha-jain @sajagana @samiib @gmicol