Addition of new module ndo_ptp_policy and its child ndo_ptp_policy_profiles (DCNE-68) #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrsr
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
samiib
as code owners
github-actions
bot
changed the title
shrsr
force-pushed
the
ptp
branch
3 times, most recently
from
9d63e54 to
b5b93e2
Compare
akinross
requested changes
Dec 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #578 +/- ##
===========================================
- Coverage 72.58% 18.15% -54.43%
===========================================
Files 55 98 +43
Lines 5504 9152 +3648
Branches 1462 2384 +922
===========================================
- Hits 3995 1662 -2333
- Misses 1174 7489 +6315
+ Partials 335 1 -334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmicol
requested changes
Dec 18, 2024
samiib
requested changes
Dec 20, 2024
…o_ptp_policy_profiles
sajagana
requested changes
Dec 23, 2024
| state: absent | ||
|
|
||
| - name: Delete a PTP policy using UUID | ||
| cisco.mso.ndo_ptp_policy_profiles: |
There was a problem hiding this comment.
Suggested change
| cisco.mso.ndo_ptp_policy_profiles: | |
| cisco.mso.ndo_ptp_policy: |
| mso.existing = mso.previous = existing_ptp_policies | ||
|
|
||
| if state == "present": | ||
| mso_values_update = { |
There was a problem hiding this comment.
Use dict() instead of {} and move it under if match:.
| append_update_ops_data(ops, match.details, path, mso_values_update) | ||
| mso.sanitize(match.details, collate=True) | ||
| else: | ||
| mso_values = { |
There was a problem hiding this comment.
Use dict() instead of {}.
| @@ -211,3 +211,5 @@ | |||
|
|
|||
| ORIGINATE_DEFAULT_ROUTE = {"only": "only", "in_addition": "inAddition", "": ""} | |||
| L3OUT_ROUTING_PROTOCOLS = {"bgp": ["bgp"], "ospf": ["ospf"], "bgpOspf": ["bgp", "ospf"], None: [None], "": None, "bgpospf": "bgpOspf", "ospfbgp": "bgpOspf"} | |||
|
|
|||
| PROFILE_TEMPLATE = {"aes67-2015": "aes67", "default": "default", "smpte-2059-2": "smpte", "telecom-8275-1": "telecomFullPath"} | |||
There was a problem hiding this comment.
Can we use _ instead of -?
| ptp_policy_profile_name=dict(type="str", aliases=["name"]), | ||
| ptp_policy_profile_uuid=dict(type="str", aliases=["uuid"]), | ||
| delay_interval=dict(type="int"), | ||
| profile_template=dict(type="str", choices=["aes67-2015", "default", "telecom-8275-1", "smpte-2059-2"]), |
There was a problem hiding this comment.
Suggested change
| profile_template=dict(type="str", choices=["aes67-2015", "default", "telecom-8275-1", "smpte-2059-2"]), | |
| profile_template=dict(type="str", choices=list(PROFILE_TEMPLATE)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.