Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: mso_tenant_site #62

Merged
merged 9 commits into from
Jun 29, 2020
Merged

New module: mso_tenant_site #62

merged 9 commits into from
Jun 29, 2020

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Jun 25, 2020

This module has the ability to:

  1. Associate cloud sites with a tenant and set its options
  2. Associate non-cloud sites with a tenant

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #62 into master will increase coverage by 1.34%.
The diff coverage is 98.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   61.22%   62.56%   +1.34%     
==========================================
  Files          38       39       +1     
  Lines        3025     3128     +103     
  Branches      815      844      +29     
==========================================
+ Hits         1852     1957     +105     
+ Misses       1029     1027       -2     
  Partials      144      144              
Flag Coverage Δ
#integration 62.56% <98.05%> (+1.34%) ⬆️
Impacted Files Coverage Δ
plugins/modules/mso_tenant_site.py 98.05% <98.05%> (ø)
plugins/module_utils/mso.py 67.33% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232b872...474df0d. Read the comment docs.

@lhercot lhercot linked an issue Jun 26, 2020 that may be closed by this pull request
@shrsr shrsr requested a review from lhercot June 27, 2020 01:41
tests/integration/targets/mso_tenant_site/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/mso_tenant_site/tasks/main.yml Outdated Show resolved Hide resolved
plugins/modules/mso_tenant_site.py Outdated Show resolved Hide resolved
plugins/modules/mso_tenant_site.py Outdated Show resolved Hide resolved
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 3ef1545 into CiscoDevNet:master Jun 29, 2020
@shrsr shrsr deleted the feature-x branch June 29, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add azure/aws support to mso_tenant
2 participants