Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mso_rest data source #184

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Add mso_rest data source #184

merged 3 commits into from
Apr 19, 2023

Conversation

danischm
Copy link
Member

No description provided.

akinross
akinross requested changes Apr 18, 2023
View reviewed changes
mso/datasource_mso_rest.go Outdated Show resolved Hide resolved
mso/datasource_mso_rest.go Outdated Show resolved Hide resolved
website/docs/d/rest.html.markdown Outdated Show resolved Hide resolved
akinross
akinross previously approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana requested changes Apr 19, 2023
View reviewed changes
mso/datasource_mso_rest.go Outdated Show resolved Hide resolved
sajagana
sajagana approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sajagana sajagana requested a review from akinross April 19, 2023 11:12
akinross
akinross approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot linked an issue Apr 19, 2023 that may be closed by this pull request
Return JSON Object from mso_rest GET requests #10
Closed
lhercot
lhercot approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 1a72c13 into CiscoDevNet:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajagana sajagana sajagana approved these changes

@akinross akinross akinross approved these changes

@lhercot lhercot lhercot approved these changes

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@shrsr shrsr Awaiting requested review from shrsr shrsr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return JSON Object from mso_rest GET requests
4 participants
@danischm @lhercot @akinross @sajagana